chore: type property to array-element-newline schema added

[mho22]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

It seems the array-element-newline rule schema has a items : [...] property without its type : "array" associated property. I compared to another rule structurally almost similar comma-dangle having it and json-schema language doesn't seem to accept a single items property for an array object.

What changes did you make? (Give an overview)

I added type: "array", on line 50 of the schema object of the array-element-newline rule

Is there anything you'd like reviewers to focus on?

no

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Itemshopp / name: MHO (d2fbb5a)

[eslint-github-bot]

Hi @itemshopp!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

[netlify]

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	d2fbb5a
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/63e3d4abe0f83d00090516fc

[eslint-github-bot]

Hi @itemshopp!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

[mdjermanovic]

LGTM, thanks!

This is a non-breaking change as it doesn't affect validations since we always pass the configured options as an array to the validator, but it's good to have the type property for consistency.

[mho22]

@mdjermanovic I figured out it probably also misses : additionalItems : false. I am sorry about that. I know this is not a urgent issue so tell me what I may do and I will. New pull request ?

[mdjermanovic]

@mdjermanovic I figured out it probably also misses : additionalItems : false. I am sorry about that. I know this is not a urgent issue so tell me what I may do and I will. New pull request ?

Indeed, the schema is missing additionalItems: false so it allows configurations such as "array-element-newline": ["error", "never", { minItems: 3 }] where the rule just ignores { "minItems": 3 } instead of throwing a configuration error.

However, per our semver policies this would be a breaking change. Can you submit a bug report so we could track this and fix it in the next major release?

[mho22]

@mdjermanovic Bug report created, thanks for your work

[mdjermanovic]

Thanks!