Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "docs: update header (#16403)" #16451

Merged
merged 1 commit into from Oct 21, 2022
Merged

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 21, 2022

This reverts commit 24950b3.

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Reverted #16403, as it breaks content widths on mobile. In particular, on mobile, you'd have to scroll left-right to read the text in paragraphs.

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Oct 21, 2022
@netlify
Copy link

netlify bot commented Oct 21, 2022

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 8473f48
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6352cf93b18e5d0008ceacca
😎 Deploy Preview https://deploy-preview-16451--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mdjermanovic mdjermanovic added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Oct 21, 2022
@mdjermanovic
Copy link
Member Author

I can reproduce this on multiple mobile devices and different browsers, so I'll go ahead and merge this.

@mdjermanovic mdjermanovic merged commit 6c2be51 into main Oct 21, 2022
@mdjermanovic mdjermanovic deleted the revert-update-header branch October 21, 2022 20:43
@mdjermanovic mdjermanovic mentioned this pull request Oct 21, 2022
1 task
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Apr 20, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant