feat: check for Object.create() without explicit return value in getter return #16420

hirasawayuki · 2022-10-13T13:04:53Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fixed to check the return value of get property in Object.create.

Is there anything you'd like reviewers to focus on?

linux-foundation-easycla · 2022-10-13T13:04:56Z

The committers listed above are authorized under a signed CLA.

✅ login: hirasawayuki / name: Yuki Hirasawa (44b2333)

netlify · 2022-10-13T13:04:57Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`8ca5597`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/63499cedecc2310008603869

mdjermanovic · 2022-10-13T20:23:52Z

Note: we should merge this change as feat because it generates more warnings.

mdjermanovic · 2022-10-13T20:50:27Z

lib/rules/getter-return.js

+                        parent.parent.parent.parent.parent.type === "CallExpression") {
+                        const calleePropName = astUtils.getStaticPropertyName(parent.parent.parent.parent.parent.callee);


It seems we forgot to check if callee.object is Object identifier.

foo.create(null, { bar: { get() {} } // false positive });

This is an inherited problem (the same happens with foo.defineProperty and foo.defineProperties), but since it will now generate even more false positives, and create is a common name, it would be good to include that fix in this change.

Thank you for review! I fixed to check the Object name and several test cases have been added 😃

eslint-github-bot · 2022-10-14T17:29:20Z

Hi @hirasawayuki!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

Fixes: eslint#16419

mdjermanovic

LGTM, thanks for contributing!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.25.0` -> `8.26.0`](https://renovatebot.com/diffs/npm/eslint/8.25.0/8.26.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.26.0`](https://github.com/eslint/eslint/releases/tag/v8.26.0) [Compare Source](eslint/eslint@v8.25.0...v8.26.0) #### Features - [`4715787`](eslint/eslint@4715787) feat: check `Object.create()` in getter-return ([#16420](eslint/eslint#16420)) (Yuki Hirasawa) - [`28d1902`](eslint/eslint@28d1902) feat: `no-implicit-globals` supports `exported` block comment ([#16343](eslint/eslint#16343)) (Sosuke Suzuki) - [`e940be7`](eslint/eslint@e940be7) feat: Use ESLINT_USE_FLAT_CONFIG environment variable for flat config ([#16356](eslint/eslint#16356)) (Tomer Aberbach) - [`dd0c58f`](eslint/eslint@dd0c58f) feat: Swap out Globby for custom globbing solution. ([#16369](eslint/eslint#16369)) (Nicholas C. Zakas) #### Bug Fixes - [`df77409`](eslint/eslint@df77409) fix: use `baseConfig` constructor option in FlatESLint ([#16432](eslint/eslint#16432)) (Milos Djermanovic) - [`33668ee`](eslint/eslint@33668ee) fix: Ensure that glob patterns are matched correctly. ([#16449](eslint/eslint#16449)) (Nicholas C. Zakas) - [`740b208`](eslint/eslint@740b208) fix: ignore messages without a `ruleId` in `getRulesMetaForResults` ([#16409](eslint/eslint#16409)) (Francesco Trotta) - [`8f9759e`](eslint/eslint@8f9759e) fix: `--ignore-pattern` in flat config mode should be relative to `cwd` ([#16425](eslint/eslint#16425)) (Milos Djermanovic) - [`325ad37`](eslint/eslint@325ad37) fix: make `getRulesMetaForResults` return a plain object in trivial case ([#16438](eslint/eslint#16438)) (Francesco Trotta) - [`a2810bc`](eslint/eslint@a2810bc) fix: Ensure that directories can be unignored. ([#16436](eslint/eslint#16436)) (Nicholas C. Zakas) - [`35916ad`](eslint/eslint@35916ad) fix: Ensure unignore and reignore work correctly in flat config. ([#16422](eslint/eslint#16422)) (Nicholas C. Zakas) #### Documentation - [`651649b`](eslint/eslint@651649b) docs: Core concepts page ([#16399](eslint/eslint#16399)) (Ben Perlmutter) - [`631cf72`](eslint/eslint@631cf72) docs: note --ignore-path not supported with flat config ([#16434](eslint/eslint#16434)) (Andy Edwards) - [`1692840`](eslint/eslint@1692840) docs: fix syntax in examples for new config files ([#16427](eslint/eslint#16427)) (Milos Djermanovic) - [`d336cfc`](eslint/eslint@d336cfc) docs: Document extending plugin with new config ([#16394](eslint/eslint#16394)) (Ben Perlmutter) #### Chores - [`e917a9a`](eslint/eslint@e917a9a) ci: add node v19 ([#16443](eslint/eslint#16443)) (Koichi ITO) - [`4b70b91`](eslint/eslint@4b70b91) chore: Add VS Code issues link ([#16423](eslint/eslint#16423)) (Nicholas C. Zakas) - [`232d291`](eslint/eslint@232d291) chore: suppress a Node.js deprecation warning ([#16398](eslint/eslint#16398)) (Koichi ITO) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1599 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

nzakas · 2022-11-03T20:46:03Z

@hirasawayuki we'd like to pay you for this contribution. Please email us at contact (at) eslint (dot) org. Thanks!

eslint-github-bot bot added triage An ESLint team member will look at this issue soon bug ESLint is working incorrectly labels Oct 13, 2022

hirasawayuki changed the title ~~fix: check for Object.create() without explicit return value in~~ fix: check for Object.create() without explicit return value in getter return Oct 13, 2022

mdjermanovic changed the title ~~fix: check for Object.create() without explicit return value in getter return~~ feat: check for Object.create() without explicit return value in getter return Oct 13, 2022

mdjermanovic requested changes Oct 13, 2022

View reviewed changes

hirasawayuki force-pushed the issue16419 branch from 44b2333 to 70b1c11 Compare October 14, 2022 17:29

feat: check for Object.create() without return value in getter-return

8ca5597

Fixes: eslint#16419

hirasawayuki force-pushed the issue16419 branch from 70b1c11 to 8ca5597 Compare October 14, 2022 17:31

hirasawayuki requested a review from mdjermanovic October 14, 2022 17:35

mdjermanovic approved these changes Oct 21, 2022

View reviewed changes

mdjermanovic added the contributor pool label Oct 21, 2022

mdjermanovic merged commit 4715787 into eslint:main Oct 21, 2022

hirasawayuki deleted the issue16419 branch October 21, 2022 14:40

eslint-github-bot bot locked and limited conversation to collaborators Apr 20, 2023

eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: check for Object.create() without explicit return value in getter return #16420

feat: check for Object.create() without explicit return value in getter return #16420

hirasawayuki commented Oct 13, 2022 •

edited

linux-foundation-easycla bot commented Oct 13, 2022 •

edited

netlify bot commented Oct 13, 2022 •

edited

mdjermanovic commented Oct 13, 2022

mdjermanovic Oct 13, 2022

hirasawayuki Oct 14, 2022

eslint-github-bot bot commented Oct 14, 2022

mdjermanovic left a comment

nzakas commented Nov 3, 2022

		parent.parent.parent.parent.parent.type === "CallExpression") {
		const calleePropName = astUtils.getStaticPropertyName(parent.parent.parent.parent.parent.callee);

feat: check for Object.create() without explicit return value in getter return #16420

feat: check for Object.create() without explicit return value in getter return #16420

Conversation

hirasawayuki commented Oct 13, 2022 • edited

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

linux-foundation-easycla bot commented Oct 13, 2022 • edited

netlify bot commented Oct 13, 2022 • edited

✅ Deploy Preview for docs-eslint canceled.

mdjermanovic commented Oct 13, 2022

mdjermanovic Oct 13, 2022

Choose a reason for hiding this comment

hirasawayuki Oct 14, 2022

Choose a reason for hiding this comment

eslint-github-bot bot commented Oct 14, 2022

mdjermanovic left a comment

Choose a reason for hiding this comment

nzakas commented Nov 3, 2022

hirasawayuki commented Oct 13, 2022 •

edited

linux-foundation-easycla bot commented Oct 13, 2022 •

edited

netlify bot commented Oct 13, 2022 •

edited