Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update header #16403

Merged
merged 1 commit into from Oct 13, 2022
Merged

Conversation

chenxsan
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update

To keep the top border of header consistent with other pages like Team/Blog which would take up the full width of viewport.

CleanShot 2022-10-10 at 18 27 43@2x

[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  1. Move .docs class to .docs-wrapper element
Before

CleanShot 2022-10-10 at 18 30 17@2x

After

CleanShot 2022-10-10 at 18 30 38@2x

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added triage An ESLint team member will look at this issue soon documentation Relates to ESLint's documentation labels Oct 10, 2022
@netlify
Copy link

netlify bot commented Oct 10, 2022

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit f74fb41
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6343f56bcd048e000801ba8f
😎 Deploy Preview https://deploy-preview-16403--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Oct 10, 2022
Copy link
Member

@kecrily kecrily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit 24950b3 into eslint:main Oct 13, 2022
@chenxsan chenxsan deleted the docs/keep-header-border-consistent branch October 14, 2022 11:35
mdjermanovic added a commit that referenced this pull request Oct 21, 2022
mdjermanovic added a commit that referenced this pull request Oct 21, 2022
@mdjermanovic
Copy link
Member

@chenxsan I had to revert this change before the latest release because it seems to break the design on mobile (please see #16451). Can you please open an issue describing the reason this change was made, so we could evaluate it and then perhaps try again to fix the problem? :)

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Apr 12, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants