New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable eslint.config.js lookup from CLI #16235
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
Looks like a couple of followups:
|
Okay, I think I got everything. 😓 |
Something is wrong when passing a directory name to lint. For example, when I run
I believe the cause is somewhere inside this code, |
Changes in this PR LGTM. The bug with directories seems to be a previously existing bug in the FlatESLint class. @nzakas what do you think about merging this for today's release? |
Since this is opt-in and still marked as an experimental feature, I'll go ahead and merge this PR for today's release. |
Change appears to break all current and historic WebStorm versions built-in plugin: |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.22.0` -> `8.23.0`](https://renovatebot.com/diffs/npm/eslint/8.22.0/8.23.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.23.0`](https://github.com/eslint/eslint/releases/tag/v8.23.0) [Compare Source](eslint/eslint@v8.22.0...v8.23.0) #### Features - [`3e5839e`](eslint/eslint@3e5839e) feat: Enable eslint.config.js lookup from CLI ([#​16235](eslint/eslint#16235)) (Nicholas C. Zakas) - [`30b1a2d`](eslint/eslint@30b1a2d) feat: add `allowEmptyCase` option to no-fallthrough rule ([#​15887](eslint/eslint#15887)) (Amaresh S M) - [`43f03aa`](eslint/eslint@43f03aa) feat: no-warning-comments support comments with decoration ([#​16120](eslint/eslint#16120)) (Lachlan Hunt) #### Documentation - [`b1918da`](eslint/eslint@b1918da) docs: package.json conventions ([#​16206](eslint/eslint#16206)) (Patrick McElhaney) - [`0e03c33`](eslint/eslint@0e03c33) docs: remove word immediately ([#​16217](eslint/eslint#16217)) (Strek) - [`c6790db`](eslint/eslint@c6790db) docs: add anchor link for "migrating from jscs" ([#​16207](eslint/eslint#16207)) (Percy Ma) - [`7137344`](eslint/eslint@7137344) docs: auto-generation edit link ([#​16213](eslint/eslint#16213)) (Percy Ma) #### Chores - [`2e004ab`](eslint/eslint@2e004ab) chore: upgrade [@​eslint/eslintrc](https://github.com/eslint/eslintrc)[@​1](https://github.com/1).3.1 ([#​16249](eslint/eslint#16249)) (Milos Djermanovic) - [`d35fbbe`](eslint/eslint@d35fbbe) chore: Upgrade to espree@9.4.0 ([#​16243](eslint/eslint#16243)) (Milos Djermanovic) - [`ed26229`](eslint/eslint@ed26229) test: add no-extra-parens tests with rest properties ([#​16236](eslint/eslint#16236)) (Milos Djermanovic) - [`deaf69f`](eslint/eslint@deaf69f) chore: fix off-by-one `min-width: 1023px` media queries ([#​15974](eslint/eslint#15974)) (Milos Djermanovic) - [`63dec9f`](eslint/eslint@63dec9f) refactor: simplify `parseListConfig` ([#​16241](eslint/eslint#16241)) (Milos Djermanovic) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzcuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE4MS4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1527 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Refs #13481
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This change enables flat config when there is an
eslint.config.js
file found:cli.js
to do this and also updated the tests. For the tests, I tried to group them more logically than they were. I also split them up into tests that are valid for both eslintrc and flat config, and ones that are not.I deleted the top-levelRemoving.eslintrc
so ESLint internally useseslint.config.js
now..eslintrc.js
messed up a lot of tests that were relying on it. This has been a constant problem in this refactor -- a lot of hidden dependencies in the repo./* globals */
instead.no-lone-blocks
to uselanguageOptions.ecmaVersion
instead ofparserOptions.ecmaVersion
.Is there anything you'd like reviewers to focus on?
Do these changes make sense? Any concerns with pushing this out?