Change Request: Allow processors to report syntax errors

[btmills]

ESLint version

v8.19.0

What problem do you want to solve?

Originally discussed in #16015, the @graphql-eslint/graphql processor is encountering a syntax error in the file that is being processed (the "physical" file, if code blocks are "virtual" files). That syntax error results in an exception thrown within the processor that currently crashes the entire lint run. It would be better if processors could report syntax errors like other parsers without crashing the whole process.

What do you think is the correct solution?

We should mimic parse()'s behavior by wrapping the preprocess() call in try/catch and transforming the exception thrown by the processor into a lint error.

Participation

• I am willing to submit a pull request for this change.

Additional comments

In the discussion, @JounQin asked to take this, but I'm also willing to tackle it as a fallback if necessary.

[JounQin]

Thanks for pinning, I'm going to work on a fix soon, then.

[JounQin]

@btmills Done in #16105.

[dimaMachina]

Thanks @JounQin 💪🏻

[mdjermanovic]

It would be better if processors could report syntax errors like other parsers without crashing the whole process.

Makes sense to me 👍

The only downside I can see is that if the processor is not stateless, continuing the work with other files after the point where throwing an error currently breaks the whole linting process might result in broken processing of subsequent files due to a possibly broken state, depending on how the processor is implemented.

[mdjermanovic]

Since @nzakas already approved the PR, it seems we have consensus to implement this change, so I'm marking it as accepted.