feat: add importNames support for patterns in no-restricted-imports

[brandongregoryscott]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Resolves #14274

What changes did you make? (Give an overview)

This change expands the functionality of no-restricted-imports to allow restricting only specific named imports from an import pattern ban. For example, if I wanted to ban importing Foo from '../../../my/relative/module', but importing Bar from the matched pattern is OK, I can now do that:

"no-restricted-imports": ["error", {            
    "patterns": [{
        "group": ["**/my/relative-module"],
        "importNames": ["Foo"],
        "message": "Don't import Foo from my/relative-module. Instead import from @repo/foo"
    }]
}]

import { Foo } from '../../../my/relative-module' // error
import { Foo, Bar } from '../../../my/relative-module' // error
import { Bar } from '../../../my/relative-module' // ok

Is there anything you'd like reviewers to focus on?

Nope - this is my first time contributing here, so please forgive me if I've missed anything - happy to update as needed!

[eslint-github-bot]

Hi @brandongregoryscott!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: brandongregoryscott / name: Brandon Scott (ba96189)

[netlify]

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	fdd0dc1
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/62bdd6bdd99aee000837df59

[eslint-github-bot]

Hi @brandongregoryscott!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

[mdjermanovic]

Thanks for working on this! I left two comments.

Also, this new feature should be documented in docs/src/rules/no-restricted-imports.md

[brandongregoryscott]

I pushed up that change @mdjermanovic, feel free to take a look when you have time! I am noticing there's some duplicated logic in here, but I'm not sure if it's a concern right now.

[mdjermanovic]

Just a few small suggestions and then LGTM.

[mdjermanovic]

I am noticing there's some duplicated logic in here, but I'm not sure if it's a concern right now.

Yes, the code that handles patterns now looks very similar to the code that handles paths, but that's okay right now. At some point later we could consider refactoring.

[mdjermanovic]

LGTM, thanks!

I'll leave this open if someone else wants to review it before merging.

[btmills]

LGTM. Thanks, and congrats on your first ESLint contribution, @brandongregoryscott! This will be going out in the release shortly.