docs: Add scroll behaviour smooth #16056

amareshsm · 2022-06-25T19:56:35Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Added scroll behaviour to smoothly animate the scroll position.

Before:

Screen.Recording.2022-06-30.at.1.25.28.AM.mov

After:

Screen.Recording.2022-06-30.at.1.25.55.AM.mov

netlify · 2022-06-25T19:56:42Z

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`f4a48aa`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/62c33bb4e40fd50009fd91df
😎 Deploy Preview	https://deploy-preview-16056--docs-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

snitin315

Why is it needed? Is there an issue with the current scroll behavior?

amareshsm · 2022-06-26T18:07:43Z

Why is it needed? Is there an issue with the current scroll behavior?

No issue with the current scroll behavior. Current scroll behavior (auto) scrolls to the position instantly so just set the value to smooth to scroll in a smooth fashion.

snitin315 · 2022-06-27T11:42:53Z

I see. can you share a before/after screenshot/video?

amareshsm · 2022-06-29T19:57:58Z

I see. can you share a before/after screenshot/video?

Updated in the PR.

snitin315 · 2022-06-30T02:13:00Z

I see other documentation websites are also using the same current behavior. Scrolling can be a problem if the page is too long. So, I'm more inclined towards the current behavior. Let's wait to see what other team members feel.

Gatsby

Screen.Recording.2022-06-30.at.7.34.10.AM.mov

Vue

Screen.Recording.2022-06-30.at.7.36.01.AM.mov

Webpack

Screen.Recording.2022-06-30.at.7.40.41.AM.mov

amareshsm · 2022-06-30T18:31:41Z

Inspired from MDN docs.

nzakas · 2022-07-02T00:52:05Z

I don’t have a strong opinion either way. I wouldn’t mind merging this to just see what feedback we get. It’s easy enough to undo if we get negative feedback.

nzakas · 2022-07-02T00:52:41Z

docs/src/assets/scss/docs.scss

@@ -1,5 +1,9 @@
 /* docs layout styles */

+html, body {


I think we only need html here

Suggested change

html, body {

html {

snitin315

Let's try this.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.19.0` -> `8.20.0`](https://renovatebot.com/diffs/npm/eslint/8.19.0/8.20.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.20.0`](https://github.com/eslint/eslint/releases/tag/v8.20.0) [Compare Source](eslint/eslint@v8.19.0...v8.20.0) #### Features - [`ca83178`](eslint/eslint@ca83178) feat: catch preprocess errors ([#16105](eslint/eslint#16105)) (JounQin) #### Bug Fixes - [`30be0ed`](eslint/eslint@30be0ed) fix: no-warning-comments rule escapes special RegEx characters in terms ([#16090](eslint/eslint#16090)) (Lachlan Hunt) - [`bfe5e88`](eslint/eslint@bfe5e88) fix: ignore spacing before `]` and `}` in comma-spacing ([#16113](eslint/eslint#16113)) (Milos Djermanovic) #### Documentation - [`845c4f4`](eslint/eslint@845c4f4) docs: Add website team details ([#16115](eslint/eslint#16115)) (Nicholas C. Zakas) - [`5a0dfdb`](eslint/eslint@5a0dfdb) docs: Link to blog post in no-constant-binary-expression ([#16112](eslint/eslint#16112)) (Jordan Eldredge) - [`bc692a9`](eslint/eslint@bc692a9) docs: remove install command ([#16084](eslint/eslint#16084)) (Strek) - [`49ca3f0`](eslint/eslint@49ca3f0) docs: don't show toc when content not found ([#16095](eslint/eslint#16095)) (Amaresh S M) - [`ba19e3f`](eslint/eslint@ba19e3f) docs: enhance 404 page UI ([#16097](eslint/eslint#16097)) (Amaresh S M) - [`a75d3b4`](eslint/eslint@a75d3b4) docs: remove unused meta.docs.category field in working-with-rules page ([#16109](eslint/eslint#16109)) (Brandon Scott) - [`cdc0206`](eslint/eslint@cdc0206) docs: add formatters page edit link ([#16094](eslint/eslint#16094)) (Amaresh S M) - [`4d1ed22`](eslint/eslint@4d1ed22) docs: preselect default theme ([#16098](eslint/eslint#16098)) (Strek) - [`4b79612`](eslint/eslint@4b79612) docs: add missing correct/incorrect containers ([#16087](eslint/eslint#16087)) (Milos Djermanovic) - [`09f6acb`](eslint/eslint@09f6acb) docs: fix UI bug on rules index and details pages ([#16082](eslint/eslint#16082)) (Deepshika S) - [`f5db264`](eslint/eslint@f5db264) docs: remove remaining duplicate rule descriptions ([#16093](eslint/eslint#16093)) (Milos Djermanovic) - [`32a6b2a`](eslint/eslint@32a6b2a) docs: Add scroll behaviour smooth ([#16056](eslint/eslint#16056)) (Amaresh S M) #### Chores - [`bbf8df4`](eslint/eslint@bbf8df4) chore: Mark autogenerated release blog post as draft ([#16130](eslint/eslint#16130)) (Nicholas C. Zakas) - [`eee4306`](eslint/eslint@eee4306) chore: update internal lint dependencies ([#16088](eslint/eslint#16088)) (Bryan Mishkin) - [`9615a42`](eslint/eslint@9615a42) chore: update formatter examples template to avoid markdown lint error ([#16085](eslint/eslint#16085)) (Milos Djermanovic) - [`62541ed`](eslint/eslint@62541ed) chore: fix markdown linting error ([#16083](eslint/eslint#16083)) (唯然) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1466 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

eslint-github-bot bot added triage An ESLint team member will look at this issue soon documentation Relates to ESLint's documentation labels Jun 25, 2022

amareshsm changed the title ~~docs: add scroll behaviour smooth~~ docs: Add scroll behaviour smooth Jun 25, 2022

docs: Add scroll behaviour smooth

035f563

amareshsm force-pushed the add-scroll-behaviour branch from cd39626 to 035f563 Compare June 25, 2022 20:07

snitin315 reviewed Jun 26, 2022

View reviewed changes

snitin315 added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jun 27, 2022

nzakas reviewed Jul 2, 2022

View reviewed changes

docs: remove body tag

f4a48aa

snitin315 approved these changes Jul 5, 2022

View reviewed changes

snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jul 5, 2022

snitin315 requested a review from nzakas July 5, 2022 12:01

mdjermanovic approved these changes Jul 5, 2022

View reviewed changes

nzakas merged commit 32a6b2a into eslint:main Jul 5, 2022

sync-by-unito bot mentioned this pull request Aug 1, 2022

build(deps-dev): bump eslint from 7.32.0 to 8.21.0 numbersprotocol/capture-lite#1868

Closed

eslint-github-bot bot locked and limited conversation to collaborators Jan 2, 2023

eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Add scroll behaviour smooth #16056

docs: Add scroll behaviour smooth #16056

amareshsm commented Jun 25, 2022 •

edited

netlify bot commented Jun 25, 2022 •

edited

snitin315 left a comment •

edited

amareshsm commented Jun 26, 2022

snitin315 commented Jun 27, 2022

amareshsm commented Jun 29, 2022

snitin315 commented Jun 30, 2022 •

edited

amareshsm commented Jun 30, 2022

nzakas commented Jul 2, 2022

nzakas Jul 2, 2022

amareshsm Jul 4, 2022

snitin315 left a comment

Navigation Menu

docs: Add scroll behaviour smooth #16056

docs: Add scroll behaviour smooth #16056

Conversation

amareshsm commented Jun 25, 2022 • edited

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

netlify bot commented Jun 25, 2022 • edited

✅ Deploy Preview for docs-eslint ready!

snitin315 left a comment • edited

Choose a reason for hiding this comment

amareshsm commented Jun 26, 2022

snitin315 commented Jun 27, 2022

amareshsm commented Jun 29, 2022

snitin315 commented Jun 30, 2022 • edited

amareshsm commented Jun 30, 2022

nzakas commented Jul 2, 2022

nzakas Jul 2, 2022

Choose a reason for hiding this comment

amareshsm Jul 4, 2022

Choose a reason for hiding this comment

snitin315 left a comment

Choose a reason for hiding this comment

amareshsm commented Jun 25, 2022 •

edited

netlify bot commented Jun 25, 2022 •

edited

snitin315 left a comment •

edited

snitin315 commented Jun 30, 2022 •

edited