Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduled release for July 1st, 2022 #16029

Closed
11 of 19 tasks
eslint-github-bot bot opened this issue Jun 20, 2022 · 4 comments
Closed
11 of 19 tasks

Scheduled release for July 1st, 2022 #16029

eslint-github-bot bot opened this issue Jun 20, 2022 · 4 comments
Assignees
@btmills
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion release This issue contains information about a scheduled ESLint release triage:no

Comments

@eslint-github-bot
Copy link

eslint-github-bot bot commented Jun 20, 2022 •
edited by btmills

The next scheduled release will occur on Friday, July 1st, 2022.

Release Day Checklist

  • Remove the 'tsc agenda' label on this issue
  • Review open pull requests and merge any that are ready
  • Start the release on Jenkins
  • Update the release blog post with a "Highlights" section
  • Make a release announcement on Twitter
  • Make a release announcement in the Discord '#announcements' channel
  • Add a comment to this issue saying the release is out
  • Add the 'patch release pending' label to this issue

Two Days After Release Day Checklist

Typically Monday for regular releases; two days after patch releases.

  • Check the issues list for any regression issues

No Regressions Checklist

  • Remove the 'patch release pending' label from this issue
  • Close this issue

Patch Release Checklist

  • Resolve the regression by merging any necessary fixes
  • Start the release on Jenkins
  • Update the release blog post with a "Highlights" section
  • Make a release announcement on Twitter
  • Make a release announcement in the Discord '#announcements' channel
  • Add a comment to this issue saying the release is out
  • Wait two days and repeat the Two Days After a Release checklist
  • Close this issue

Followup

Please use this issue to document how the release went, any problems during the release, and anything the team might want to know about the release process. This issue should be closed after all patch releases have been completed (or there was no patch release needed).

Resources:
@eslint-github-bot eslint-github-bot bot added release This issue contains information about a scheduled ESLint release triage:no tsc agenda This issue will be discussed by ESLint's TSC at the next meeting labels Jun 20, 2022
@mdjermanovic mdjermanovic mentioned this issue Jun 30, 2022
Closed
1 task
@btmills btmills self-assigned this Jul 2, 2022
@btmills btmills removed the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Jul 2, 2022
@btmills
Copy link
Member

btmills commented Jul 2, 2022

ESLint v8.19.0 has been released: https://eslint.org/blog/2022/07/eslint-v8.19.0-released/

I encountered two issues during the release process:

  1. The initial site build failed with Error: template not found: partials/author_bios/.md. You can repro this yourself running git checkout v8.19.0 && npm run build. It worked after I added highlights, and I'm guessing swapping eslintbot for myself as the author had something to do with it.
  2. eslint/eslint CI is currently failing on main because of a lint issue introduced during the build.

@btmills btmills added the patch release pending A new release just shipped. No enhancements will be merged for a few days in case a patch is needed label Jul 2, 2022
btmills added a commit to eslint/eslint.org that referenced this issue Jul 2, 2022
@btmills
fix: Add eslintbot to all_authors.json
b1ec145 
`eslintbot` is the default author of the release blog posts. As-is,
after a release, website builds will fail until the person doing the
release replaces their username in the blog post's frontmatter. Is that
a feature? If so, we could provide a friendlier error or perhaps even
have the release process prepopulate it from Jenkins.

This handles the first issue I encountered in
eslint/eslint#16029.
@mdjermanovic
Copy link
Member

  1. The initial site build failed with Error: template not found: partials/author_bios/.md. You can repro this yourself running git checkout v8.19.0 && npm run build. It worked after I added highlights, and I'm guessing swapping eslintbot for myself as the author had something to do with it.

This is probably because eslintbot user is missing from all_authors.json. We added this user in eslint/eslint.org#236, but the daily update script removed it in eslint/eslint.org@db3b33b. There's an open issue to fix this: eslint/eslint.org#238

  1. eslint/eslint CI is currently failing on main because of a lint issue introduced during the build.

I merged #16083 to fix CI, and prepared #16085 to avoid this.

@aladdin-add
Copy link
Member

seems no regression issues reported.🎉

@btmills btmills removed the patch release pending A new release just shipped. No enhancements will be merged for a few days in case a patch is needed label Jul 5, 2022
@btmills
Copy link
Member

btmills commented Jul 5, 2022

I concur. Done with this release!

@btmills btmills closed this as completed Jul 5, 2022
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 2, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@btmills btmills

Labels
archived due to age This issue has been archived; please open a new issue for any further discussion release This issue contains information about a scheduled ESLint release triage:no
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@btmills @aladdin-add @mdjermanovic