Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new docs site] print style is broken #15948

Closed
1 task
Tracked by #117
mdjermanovic opened this issue May 31, 2022 · 3 comments
Closed
1 task
Tracked by #117

[new docs site] print style is broken #15948

mdjermanovic opened this issue May 31, 2022 · 3 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects
Triage

Comments

@mdjermanovic
Copy link
Member

mdjermanovic commented May 31, 2022 •
edited

Environment

main branch and docs-ui-update branch.

npm start in the docs directory.

What parser are you using?

Default (Espree)

What did you do?

Ctrl-P in Chrome to print the docs homepage.

What did you expect to happen?

Document without unnecessary navigation elements.

What actually happened?

With the current main version, there is an unnecessary "Table of Contents" select.

main branch

image

With the docs-ui-update version, there are even more unnecessary elements.

docs-ui-update branch

image

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@mdjermanovic mdjermanovic added bug ESLint is working incorrectly documentation Relates to ESLint's documentation labels May 31, 2022
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage May 31, 2022
@mdjermanovic mdjermanovic mentioned this issue May 31, 2022
Merged
1 task
@nzakas nzakas added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 4, 2022
@nzakas nzakas moved this from Needs Triage to Ready to Implement in Triage Jun 4, 2022
@amareshsm
Copy link
Member

I would like to work this bug. Can I pick this?

@snitin315
Copy link
Contributor

I would like to work this bug. Can I pick this?

@amareshsm Yes, feel free to send a PR

@mdjermanovic mdjermanovic changed the title Bug: [new docs site] print style [new docs site] print style is broken Jun 16, 2022
@mdjermanovic mdjermanovic mentioned this issue Jun 16, 2022
Closed
21 tasks
@amareshsm amareshsm mentioned this issue Jun 18, 2022
Merged
1 task
@harish-sethuraman harish-sethuraman mentioned this issue Jun 18, 2022
Merged
1 task
@mdjermanovic
Copy link
Member Author

Fixed by #16025 and #16020

Triage automation moved this from Ready to Implement to Complete Jun 21, 2022
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 19, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects
Triage
Archived in project
Triage
Complete
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nzakas @amareshsm @mdjermanovic @snitin315