Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary module namespace names (quoted export names) #15465

Closed
11 of 13 tasks
mdjermanovic opened this issue Dec 29, 2021 · 2 comments
Closed
11 of 13 tasks

Support arbitrary module namespace names (quoted export names) #15465

mdjermanovic opened this issue Dec 29, 2021 · 2 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features new syntax This issue is related to new syntax that has reached stage 4 rule Relates to ESLint's core rules
Projects

Comments

@mdjermanovic
Copy link
Member

mdjermanovic commented Dec 29, 2021

What is the name of the syntax to implement?

Arbitrary module namespace names

Please provide the TC39 URL for the syntax proposal:

This syntax was proposed directly in a normative change PR tc39/ecma262#2154, there wasn't a proposal in https://github.com/tc39/proposals. The PR is merged for ES2022 spec.

Please provide some example code for the new syntax:

import { " 👶 " as foo } from "mod";

export { foo as " 👶 " };

export { foo as " 👶 " } from "mod";

export { " 👶 " as foo } from "mod";

export { " 👶 " as " 👍 " } from "mod";

export { " 👶 " } from "mod";

export * as " 👶 " from "mod";

Implementation Checklist

Please check off all items that have already been completed. Be sure to paste the pull request URLs next to each item so we can verify the work as done.

Are you willing to submit a pull request to implement this syntax?

Yes.

@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion new syntax This issue is related to new syntax that has reached stage 4 labels Dec 29, 2021
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Dec 29, 2021
@mdjermanovic mdjermanovic moved this from Needs Triage to Ready to Implement in Triage Dec 29, 2021
@mdjermanovic mdjermanovic moved this from Ready to Implement to Blocked in Triage Dec 29, 2021
@mdjermanovic mdjermanovic moved this from Blocked to Ready to Implement in Triage Jan 2, 2022
@mdjermanovic
Copy link
Member Author

Working on keyword-spacing.

mdjermanovic added a commit that referenced this issue Jan 5, 2022
…ts (#15478)

* feat: Support arbitrary module namespace names in no-restricted-exports

Refs #15465

* align quotes
mdjermanovic added a commit that referenced this issue Jan 10, 2022
…15493)

* feat: Support arbitrary module namespace names in no-useless-rename

Refs #15465

* remove extra blank line
@mdjermanovic
Copy link
Member Author

All planned tasks are done.

Triage automation moved this from Ready to Implement to Complete Jan 10, 2022
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jul 10, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features new syntax This issue is related to new syntax that has reached stage 4 rule Relates to ESLint's core rules
Projects
Archived in project
Triage
Complete
Development

No branches or pull requests

1 participant