New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to define eslint-disable-next-line
in multiple lines
#15436
feat: allow to define eslint-disable-next-line
in multiple lines
#15436
Conversation
This comment has been minimized.
This comment has been minimized.
eslint-disable-next-line
directive in multiple lineseslint-disable-next-line
in multiple lines
It would be good to update this section in the docs with multiline https://eslint.org/docs/user-guide/configuring/rules#using-configuration-comments-1 |
4c831ed
to
e10efd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Since this is a change in the core, I'll leave it open for a few days in case someone else wants to review it, and then merge.
@snitin315 some of us prefer to reserver Is there any chance support could be added for this? I assume it was not as part of this as I cannot see it in the docs: // eslint-disable-next-line global-require -- Some text here as well
// description on why this exception is seen as appropriate but past a
// comfortable reading line length |
@thernstig please open a new issue for this. |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Other, please explain: Allow
eslint-disable-next-line
directive to be of multiple linesWhat changes did you make? (Give an overview)
Fixes #14284
Is there anything you'd like reviewers to focus on?
None