fix: improve autofix of prefer-object-has-own
#15419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
triage
snitin315
added
accepted
fisker
reviewed
Dec 11, 2021
fisker
reviewed
Dec 11, 2021
snitin315
force-pushed
the
fix/improve-autofix-prefer-object-has-own
branch
from
548eb55
to
c7367b5
Compare
fisker
reviewed
Dec 11, 2021
fisker
approved these changes
Dec 11, 2021
mdjermanovic
requested changes
Dec 12, 2021
snitin315
force-pushed
the
fix/improve-autofix-prefer-object-has-own
branch
from
767fb28
to
95e7cd3
Compare
snitin315
force-pushed
the
fix/improve-autofix-prefer-object-has-own
branch
from
52b954c
to
46ab859
Compare
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Resolve #15346 (comment)
Improve autofix for the case -
return{}.hasOwnProperty.call(object, property)Is there anything you'd like reviewers to focus on?
No