Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert changes to reported locations in max-lines-per-function #15397

Merged
merged 1 commit into from Dec 7, 2021

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Fixes #15390, reverts #15140

What changes did you make? (Give an overview)

Reverted 8f44cf5.

Is there anything you'd like reviewers to focus on?

Revert "feat: report only lines that exceed the limit in max-lines-per-function (#15140)"

This reverts commit 8f44cf5.
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion patch candidate This issue may necessitate a patch release in the next few days labels Dec 7, 2021
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Dec 7, 2021
@mdjermanovic mdjermanovic merged commit 234e3d9 into main Dec 7, 2021
@mdjermanovic mdjermanovic deleted the issue15390 branch December 7, 2021 01:24
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 6, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly patch candidate This issue may necessitate a patch release in the next few days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: max-lines-per-function changes in eslint 8.4.0
3 participants