New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use node v16
for Verify Files
#15364
Conversation
.github/workflows/ci.yml
Outdated
node-version: '12' | ||
node-version: '16.x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're still using Node 12 to build the site (including demo), so it might be better to keep 12 here until we update that on Netlify.
https://app.netlify.com/sites/eslint/deploys/61a2da6c120b9b0008f32b86
2:25:57 AM: Now using node v12.22.7 (npm v6.14.15)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update it on Netlifly soon.
We're still using Node 12 to build the site (including demo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Other, please explain: Update CI jobs
What changes did you make? (Give an overview)
Use node LTS version (v16) for jobs on CI.
Is there anything you'd like reviewers to focus on?
No