Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use node v16 for Verify Files #15364

Merged
merged 2 commits into from Nov 29, 2021
Merged

ci: use node v16 for Verify Files #15364

merged 2 commits into from Nov 29, 2021

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Other, please explain: Update CI jobs

What changes did you make? (Give an overview)

Use node LTS version (v16) for jobs on CI.

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Nov 28, 2021
node-version: '12'
node-version: '16.x'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still using Node 12 to build the site (including demo), so it might be better to keep 12 here until we update that on Netlify.

https://app.netlify.com/sites/eslint/deploys/61a2da6c120b9b0008f32b86

2:25:57 AM: Now using node v12.22.7 (npm v6.14.15)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update it on Netlifly soon.

We're still using Node 12 to build the site (including demo)
@mdjermanovic mdjermanovic changed the title ci: use node v16 ci: use node v16 for Verify Files Nov 29, 2021
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Nov 29, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit ba58d94 into main Nov 29, 2021
@mdjermanovic mdjermanovic deleted the ci/use-node-16 branch November 29, 2021 13:46
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 29, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants