Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update prefer-const for class static blocks #15325

Merged
merged 1 commit into from Nov 18, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Nov 17, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Refs #15016, fixes prefer-const

What changes did you make? (Give an overview)

This PR fixes false negatives of the prefer-const rule at the top level of class static blocks.

Example of a false negative:

/* eslint prefer-const: "error" */

class C {
    static {
        let a;
        a = 0; 
    }
}

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion new syntax This issue is related to new syntax that has reached stage 4 labels Nov 17, 2021
Fixes false negatives at the top level of class static blocks.

Refs #15016
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@mdjermanovic mdjermanovic merged commit fd5a0b8 into main Nov 18, 2021
@mdjermanovic mdjermanovic deleted the staticblocks-preferconst branch November 18, 2021 20:48
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 18, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion new syntax This issue is related to new syntax that has reached stage 4 rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants