New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update brace-style for class static blocks #15322
Conversation
Updates the `brace-style` rule to apply to braces of class static blocks. Refs #15016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments — some of the fixes look broken to me. If this is expected, can you add some comments around the invalid tests explaining why?
output: unIndent` | ||
class C { | ||
static { | ||
foo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t this be indented more?
output: unIndent` | ||
class C { | ||
static { | ||
foo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. This doesn’t properly indented.
I added a comment explaining this. Indentation is expected to be fixed by the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Refs #15016, fixes
brace-style
.What changes did you make? (Give an overview)
Updated the
brace-style
rule to apply to braces of class static blocks.Is there anything you'd like reviewers to focus on?