feat: update max-statements for class static blocks #15315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Refs #15016, fixes
max-statements
.What changes did you make? (Give an overview)
Updated the
max-statements
rule so that it does not apply to class static blocks and does not count statements in them as statements of the enclosing function.Is there anything you'd like reviewers to focus on?
Before this change, the behavior of this rule was:
Statements at the top level of static blocks did not count at all. Statements in nested blocks of static blocks did count, as statements of the enclosing function.
This didn't make sense, and possible fixes were:
foo
would have 8 statements.foo
would have 2 statements, while the static block itself would be reported as it would have 6 statements.foo
would have 2 statements, while the static block and its nested blocks would be ignored.I implemented option 3.
I think that static block shouldn't be seen as a block in the function (option 1). Both options 2 and 3 make sense to me, but the documentation for this rule states multiple times that it applies to "functions", so given the conversation in #15016, it looked like this rule should not apply to static blocks, or at least not by default.