Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update vars-on-top for class static blocks #15306

Merged
merged 1 commit into from Nov 21, 2021
Merged

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Refs #15016, fixes vars-on-top.

What changes did you make? (Give an overview)

Fixed the vars-on-top rule to allow var declarations at the top of class static blocks.

/*eslint vars-on-top: "error"*/

class C {
    method() {
        var foo; // allowed
    }

    static {
        var foo; // should be allowed, too
    }
}

Is there anything you'd like reviewers to focus on?

Fixes the `vars-on-top` rule to allow `var` declarations at the top of class static blocks.

Refs #15016
@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion new syntax This issue is related to new syntax that has reached stage 4 labels Nov 12, 2021
@btmills btmills merged commit 8aa7645 into main Nov 21, 2021
@btmills btmills deleted the staticblocks-varsontop branch November 21, 2021 05:40
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 21, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion new syntax This issue is related to new syntax that has reached stage 4 rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants