Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Request: If ecmaVersion: latest pass ecmaVersion: 6 to eslint-scope #15256

Closed
1 task done
ota-meshi opened this issue Nov 4, 2021 · 1 comment · Fixed by #15268
Closed
1 task done

Change Request: If ecmaVersion: latest pass ecmaVersion: 6 to eslint-scope #15256

ota-meshi opened this issue Nov 4, 2021 · 1 comment · Fixed by #15268
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
Triage

Comments

@ota-meshi
Copy link
Member

ESLint version

v8.1.0

What problem do you want to solve?

I want to resolve a problem where a user uses a parser other than espree and uses ecmaVersion: latest to reject syntax such as import statements as an error.

Currently vue-eslint-parser can accept and parse ecmaVersion: latest, but users can't actually use with ESLint because of an error in eslint-scope.

Related to: vuejs/vue-eslint-parser#135, eslint/eslint-scope#78

What do you think is the correct solution?

I want to change ESLint to pass ecmaVersion: 6 to eslint-scope if the user sets ecmaVersion: latest.

eslint/lib/linter/linter.js

Line 629 in 3630211

ecmaVersion,

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response
@ota-meshi ota-meshi added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon labels Nov 4, 2021
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Nov 4, 2021
@nzakas nzakas added accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Nov 6, 2021
@nzakas
Copy link
Member

nzakas commented Nov 6, 2021

In general, we should pass ecmaVersion 6 to eslint-scope whenever a non-numeric ecmaVersion is found.

@nzakas nzakas moved this from Needs Triage to Ready to Implement in Triage Nov 6, 2021
@ota-meshi ota-meshi mentioned this issue Nov 6, 2021
Merged
1 task
Triage automation moved this from Ready to Implement to Complete Nov 9, 2021
@mdjermanovic mdjermanovic mentioned this issue Nov 27, 2021
Merged
16 tasks
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 9, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
Triage
Archived in project
Triage
Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Normalize ecmaVersion to eslint-scope when using custom parser
2 participants
@nzakas @ota-meshi