Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for private-in syntax (fixes #14811) #15060

Merged
merged 1 commit into from Nov 21, 2021
Merged

feat: support for private-in syntax (fixes #14811) #15060

merged 1 commit into from Nov 21, 2021

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Sep 14, 2021

WIP

Remaining steps:


Fixes #14811.

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Upgrade the espree.

What changes did you make? (Give an overview)

This PR adds support for ES2022 private-in.
I have changed the space-unary-ops rule that we know needs to be changed.

Is there anything you'd like reviewers to focus on?

I checked keyword-spacing rule, which is similar to space-unary-ops rule, but the rule already seems to work well with return#x in obj.

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Sep 14, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 14, 2021

CLA Signed

The committers are authorized under a signed CLA.

@ota-meshi ota-meshi marked this pull request as draft September 14, 2021 08:28
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion new syntax This issue is related to new syntax that has reached stage 4 rule Relates to ESLint's core rules upgrade This change is related to a dependency upgrade and removed triage An ESLint team member will look at this issue soon labels Sep 14, 2021
@mdjermanovic mdjermanovic added the blocked This change can't be completed until another issue is resolved label Sep 24, 2021
@mdjermanovic mdjermanovic changed the title Update: support for private-in syntax (fixes #14811) feat: support for private-in syntax (fixes #14811) Oct 26, 2021
@eslint-github-bot
Copy link

Hi @ota-meshi!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

Read more about contributing to ESLint here

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! We just need to release espree and update package.json, and then this can be merged.

@btmills btmills marked this pull request as ready for review November 21, 2021 05:18
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Espree was just updated in #15338, so this is good to go! LGTM

@btmills btmills merged commit e2fe7ef into eslint:main Nov 21, 2021
@ota-meshi ota-meshi deleted the private-in branch November 21, 2021 05:23
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 21, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion blocked This change can't be completed until another issue is resolved new syntax This issue is related to new syntax that has reached stage 4 rule Relates to ESLint's core rules upgrade This change is related to a dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for #x in obj private-in syntax
3 participants