Chore: Add test that deprecated rules display a deprecated notice #14989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
triage
bmish
reviewed
Aug 28, 2021
| @@ -1,5 +1,6 @@ | |||
| # enforce consistent indentation (indent-legacy) | |||
|
|
|||
| This rule was **deprecated** in ESLint v4.0.0. | |||
There was a problem hiding this comment.
Should have blank line after:
Suggested change
| This rule was **deprecated** in ESLint v4.0.0. | |
| This rule was **deprecated** in ESLint v4.0.0. | |
bmish
reviewed
Aug 28, 2021
bmish
changed the title
bmish
approved these changes
Aug 29, 2021
aladdin-add
added
accepted
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: Add tests
What changes did you make? (Give an overview)
I update deprecated information at #14961 and turned out we need to add some more tests.
#14961 (comment)
Is there anything you'd like reviewers to focus on?