Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: change reporting location for curly rule (refs #12334) #14766

Merged
merged 6 commits into from Jul 30, 2021

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Refers #12334

Fixes #13282

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Jul 4, 2021
@snitin315 snitin315 changed the title Update: change reporting location for curly rule Update: change reporting location for curly rule (refs #12334) Jul 4, 2021
@snitin315 snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Jul 4, 2021
@mdjermanovic
Copy link
Member

Now I think that highlighting the body/consequent/alternate node would make the most sense, as that's the part of the code that should be fixed. The rule reports "Expected '{' after 'while' condition.", but the whole body should be wrapped in a block. A similar rule arrow-body-style reports body.loc as the error location.

@snitin315
Copy link
Contributor Author

Makes sense, I will update 👍

@snitin315
Copy link
Contributor Author

@mdjermanovic updated 👍🏻

lib/rules/curly.js Outdated Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@btmills btmills merged commit faecf56 into master Jul 30, 2021
@btmills btmills deleted the update/curly-report-location branch July 30, 2021 22:30
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 27, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants