New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: change reporting location for curly
rule (refs #12334)
#14766
Conversation
curly
rulecurly
rule (refs #12334)
Now I think that highlighting the body/consequent/alternate node would make the most sense, as that's the part of the code that should be fixed. The rule reports "Expected '{' after 'while' condition.", but the whole body should be wrapped in a block. A similar rule |
Makes sense, I will update 👍 |
@mdjermanovic updated 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Refers #12334
Fixes #13282
Is there anything you'd like reviewers to focus on?
No