New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Add only to RuleTester (refs eslint/rfcs#73) #14677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btmills
added
core
Relates to ESLint's core APIs and features
accepted
There is consensus among the team that this change meets the criteria for inclusion
feature
This change adds a new feature to ESLint
labels
Jun 6, 2021
aladdin-add
reviewed
Jun 7, 2021
Makes sense to me, some customizations might "just work". If it doesn't work by itself, they can override |
mdjermanovic
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
We can revisit the use of this
in static accessors later.
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
eslint-github-bot
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
core
Relates to ESLint's core APIs and features
feature
This change adds a new feature to ESLint
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This implements RFC73.
RuleTester
test cases support a newonly
property to run an individual case or subset of cases for less noisy debugging. We do not implement test exclusivity insideRuleTester
, instead relying on the test framework to provide that functionality when we callonly()
.Is there anything you'd like reviewers to focus on?
RuleTester[IT]
is set and has anonly
function property, returnFunction.bind.call(this[IT].only, this[IT])
." For users who customizeRuleTester.it
, this could makeonly
work without any additional configuration, but if their overriddenit
has anonly
function property with different semanticts than Mocha's, this step wouldn't work. Are we okay with this change?RuleTester
tests overrideRuleTester.it
andRuleTester.only
, testing theitOnly
getter was complex.