Chore: merge all html formatter files into html.js
#14612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
We encountered the following problem during the release.
The
gensite
script reads the content of./lib/cli-engine/formatters/
eslint/Makefile.js
Line 413 in 9e9b5e0
and then uses all found
.js
files as formatters, in order to generate https://eslint.org/docs/user-guide/formatters/ pageeslint/Makefile.js
Lines 443 to 451 in 9e9b5e0
The problem is that after #14287, that directory contains
.js
helper files for the html formatter, but those helper files are not formatters.What changes did you make? (Give an overview)
Merged all
html-*.js
files into the mainhtml.js
.Is there anything you'd like reviewers to focus on?