Chore: use includes instead of indexOf #14607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
triage
Connormiha
force-pushed
the
fix-includes-index-of
branch
from
e2033ba
to
44661b5
Compare
mdjermanovic
changed the title
mdjermanovic
added
chore
mdjermanovic
requested changes
May 21, 2021
There was a problem hiding this comment.
Hi @Connormiha, thanks for the PR!
The changes look good, but the callback-return rule is deprecated, so we don't intend to make any changes in its code. Can you please revert the changes in that file, and leave only those in comma-spacing.js?
Connormiha
force-pushed
the
fix-includes-index-of
branch
from
44661b5
to
afe0c7f
Compare
Done |
mdjermanovic
approved these changes
May 21, 2021
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
I just replaced
indexOf -1->includesin some placesWhat changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?