New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: no-unused-vars false negative with comma operator (fixes #14325) #14354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
triage
An ESLint team member will look at this issue soon
label
Apr 23, 2021
aladdin-add
added
accepted
There is consensus among the team that this change meets the criteria for inclusion
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
and removed
triage
An ESLint team member will look at this issue soon
labels
Apr 23, 2021
mdjermanovic
changed the title
Fix: report error for sequence expression in no-unused-vars
Update: report error for sequence expression in no-unused-vars
Apr 23, 2021
mdjermanovic
requested changes
Apr 23, 2021
mdjermanovic
requested changes
May 13, 2021
@mdjermanovic Thanks for the feedback, I have applied your suggestions 🚀 |
mdjermanovic
approved these changes
May 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
mdjermanovic
changed the title
Update: report error for sequence expression in no-unused-vars
Update: no-unused-vars false negative with comma operator (fixes #14325)
May 21, 2021
@aladdin-add do you still have concerns about this change? |
aladdin-add
approved these changes
May 21, 2021
Thanks for contributing! |
1 task
eslint-github-bot
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fixes #14325
Make sure to report an error in the following case -
Is there anything you'd like reviewers to focus on?
No