Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: no-unused-vars false negative with comma operator (fixes #14325) #14354

Merged
merged 7 commits into from May 21, 2021
Merged

Update: no-unused-vars false negative with comma operator (fixes #14325) #14354

merged 7 commits into from May 21, 2021

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Apr 23, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fixes #14325

Make sure to report an error in the following case -

let x = 0;
x++, x = 0;
x = 3;

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Apr 23, 2021
@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Apr 23, 2021
@aladdin-add aladdin-add self-requested a review April 23, 2021 11:45
@mdjermanovic mdjermanovic changed the title Fix: report error for sequence expression in no-unused-vars Update: report error for sequence expression in no-unused-vars Apr 23, 2021
lib/rules/no-unused-vars.js Outdated Show resolved Hide resolved
lib/rules/no-unused-vars.js Outdated Show resolved Hide resolved
lib/rules/no-unused-vars.js Show resolved Hide resolved
tests/lib/rules/no-unused-vars.js Show resolved Hide resolved
@snitin315
Copy link
Contributor Author

@mdjermanovic Thanks for the feedback, I have applied your suggestions 🚀

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic changed the title Update: report error for sequence expression in no-unused-vars Update: no-unused-vars false negative with comma operator (fixes #14325) May 21, 2021
@mdjermanovic
Copy link
Member

@aladdin-add do you still have concerns about this change?

@mdjermanovic mdjermanovic merged commit 9e9b5e0 into eslint:master May 21, 2021
@mdjermanovic
Copy link
Member

Thanks for contributing!

@snitin315 snitin315 deleted the fix-14325 branch May 22, 2021 00:19
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Nov 18, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-unused-vars does not report error when comma operator is used
4 participants