no-redeclare loose parser tests

[mdjermanovic]

The version of ESLint you are using.

v7.24.0

The problem you want to solve.

We have several tests for the no-redeclare rule where let and const variables are redeclared:

eslint/tests/lib/rules/no-redeclare.js

Lines 208 to 216 in 555cbf3

	// let/const
	{
	code: "let a; let a;",
	parser: looseParserPath,
	parserOptions: { ecmaVersion: 2015 },
	errors: [
	{ message: "'a' is already defined.", type: "Identifier" }
	]
	},

This is normally a syntax error reported by the parser, so the tests are using fixture parser tests/tools/loose-parser.js

The fixture parser requires an internal module from espree in order to produce an error-tolerant parser.

eslint/tests/tools/loose-parser.js

Line 10 in 555cbf3

const espree = require("espree/lib/espree");

The problem is - after we release eslint/espree#469, that module will be no more available as it isn't defined by exports in espree's package.json. Even if we could bypass this restriction, the module will be ESM so it can't be required.

Your take on the correct solution to problem.

Just remove those tests? Core rules are not generally designed to handle code that has syntax errors, at least for now.

Are you willing to submit a pull request to implement this change?

Yes.

[nzakas]

I agree, let's remove the tests.