Docs: fix broken links in Node.js API docs toc #14296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
triage
aladdin-add
added
accepted
mdjermanovic
reviewed
Apr 7, 2021
|
@mdjermanovic I appreciate your review. I fixed what you commented and signed the |
|
Thanks for contributing! |
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
I was reading the Node.js API page and I noticed that the links in the table of contents don't work in the website. This PR only remove hyphen from the link references to fix those links in the website.
I'm aware that currently there is the opened PR #13415 but I notice that there wasn't any activity for about 9 months.
Since I found this issue and probably other people will stumble on it, I thought to go ahead and open this PR with a smaller scope to speed the push of the fix like #13771 (and because of my faltering English, I borrowed comment from the PR)
Is there anything you'd like reviewers to focus on?