Fix: no-unused-vars ignoreRestSiblings check assignments (fixes #14163) #14264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
triage
nzakas
requested changes
Apr 1, 2021
lib/rules/no-unused-vars.js
Outdated
| REST_PROPERTY_TYPE.test(patternNode.properties[patternNode.properties.length - 1].type) | ||
| ); | ||
| }); | ||
| const hasRestSiblingDef = variable.defs.some(def => hasRestSibling(def.name.parent)); |
There was a problem hiding this comment.
Could we extend these variable names to hasRestSiblingDefinition and hasRestSiblingReference? Right now these are a bit hard to distinguish from one another.
There was a problem hiding this comment.
@nzakas Thanks for the review. I fixed it. 👍
mdjermanovic
added
accepted
nzakas
requested changes
Apr 2, 2021
mdjermanovic
changed the title
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fixes #14163 by checking references also.
Is there anything you'd like reviewers to focus on?
no.