Upgrade: pin @babel/code-frame@7.12.11

[mdjermanovic]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

We're using @babel/code-frame for the codeframe formatter.

The latest @babel/code-frame version 7.12.13, which was released yesterday, is causing failures on our CI:

https://github.com/eslint/eslint/pull/14012/checks?check_run_id=1826678459

Tests are failing because 7.12.13 produces different output for empty lines: babel/babel#12567. That change is intentional. In particular, it removes a trailing space after | if the line is empty.

7.12.13 is in the specified range:

eslint/package.json

Line 49 in 4cab165

"@babel/code-frame": "^7.0.0",

What changes did you make? (Give an overview)

• Fixed the failing tests to match the behavior of v7.12.13.

• Updated "@babel/code-frame": "^7.12.13" in package.json.

Pinned @babel/code-frame to 7.12.11 (that's the previous version, there is no 7.12.12).

Is there anything you'd like reviewers to focus on?

The change in @babel/code-frame changes the output of our codeframe formatter. An alternative is to pin @babel/code-frame to a previous version and upgrade in the next ESLint major. Another alternative is to update the code in the formatter to restore the previous output, if possible.

• As we probably don't want to stay on 7.12.11 forever, the next ESLint major version should have ^7.12.13 (or higher). That will be a breaking change in the codeframe formatter.
• An alternative is that we modify the output to match the previous behavior.

[nzakas]

It might be better to pin to the previous version. I don’t think we’ve ever made changes to formatter output outside of a major release.

[mdjermanovic]

Pinned to 7.12.11 and updated the PR description.

[mdjermanovic]

It seems we have a consensus to pin @babel/code-frame for now, so I'm merging this and will open a follow-up issue.