New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: eslint --env-info output os info #14059
Conversation
I’m not sure it’s worth adding another dependency just to output debug information. Couldn’t we just use process.platform? |
the package can output more readable info, e.g. osName('win32', '6.3.9600');
//=> 'Windows 8.1' I think either is fine. will remove the dependency if you prefer that way. :) |
As I said, I just don’t think this is important enough to add another dependency. Win32 or Win64 is plenty of info for our purposes. |
023f50b
to
8c513d9
Compare
just rebased the latest master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think we can already mark this as accepted, since it matches our new bug report template. |
os.platform = () => "darwin"; | ||
os.release = () => "20.3.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use sinon
here to prevent this change from leaking to other tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ x] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
eslint --env-info
print the os info, it looks like:Is there anything you'd like reviewers to focus on?
no.