New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: remove configuring.md #14036
Docs: remove configuring.md #14036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's no longer required - we have docs/user-guide/configuring/README.md
I think the 301s should be okay. If we are concerned, I think we can configure that behavior in Netlify. |
My concern is if someone (user or crawler) has somewhere cached that Hopefully, it will ask again for |
301s are temporary redirects, so there should be minimal caching, if any. |
301 is permanent redirect, 302 is temporary. https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's our backup plan if it turns out the preexisting 301 from configuring/
to configuring
ends up breaking something in combination with the new 301 from configuring
back to configuring/
? Rename the new docs to configuration/
and redirect configuring/?
there?
Sounds good to me! |
Documentation about "Adding Shared Settings" is moved by eslint/eslint#13837 and eslint/eslint#14036.
Documentation about "Adding Shared Settings" is moved by eslint/eslint#13837 and eslint/eslint#14036.
Documentation about "Adding Shared Settings" is moved by eslint/eslint#13837 and eslint/eslint#14036.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
The actual URL for the Configuring ESLint page is:
configuring.html
content, created fromconfiguring.md
)Now that we have merged #13837, the new URL should be:
configuring/index.html
content, created fromconfiguring/README.md
)This is a different URL, note
/
at the end.The problem is that, if we don't remove
configuring.html
, Netlify redirectshttps://eslint.org/docs/user-guide/configuring/
tohttps://eslint.org/docs/user-guide/configuring
and serves the content ofconfiguring.html
.What changes did you make? (Give an overview)
Removed
configuring.md
so that we don't haveconfiguring.html
on the website.With this change, Netlify will also be redirecting all old
https://eslint.org/docs/user-guide/configuring
links tohttps://eslint.org/docs/user-guide/configuring/
, as in this preview: eslint/archive-website#824Is there anything you'd like reviewers to focus on?
https://eslint.org/docs/user-guide/configuring/
tohttps://eslint.org/docs/user-guide/configuring
. The next version will be doing the opposite. Could that make any problems (caches, SEO...)?