Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init option adds in id-blacklist #14017

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly cli Relates to ESLint's command-line interface
Projects

Comments

@Yash-Singh1
Copy link
Contributor

I ran eslint --init on the command line and the result contained:

"id-blacklist": "error",
"id-denylist": "error"

id-blacklist was deprecated and replaced by id-denylist, so the resulting config should not contain the id-blacklist rule.

@Yash-Singh1 Yash-Singh1 added bug ESLint is working incorrectly triage An ESLint team member will look at this issue soon labels Jan 19, 2021
@mdjermanovic mdjermanovic added cli Relates to ESLint's command-line interface evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jan 19, 2021
@mdjermanovic
Copy link
Member

Hi @Yash-Singh1, thanks for the issue!

Can you please share --init steps (i.e. the options you selected) that lead to this?

@Yash-Singh1
Copy link
Contributor Author

Yash-Singh1 commented Jan 24, 2021

The following is my answers to the --init questions:

? How would you like to use ESLint? … 
  To check syntax only
  To check syntax and find problems
▸ To check syntax, find problems, and enforce code style

? What type of modules does your project use? … 
  JavaScript modules (import/export)
▸ CommonJS (require/exports)
  None of these

? Which framework does your project use? … 
  React
  Vue.js
▸ None of these

? Does your project use TypeScript? ‣ No / Yes

? Where does your code run? …  (Press <space> to select, <a> to toggle all, <i> to invert selection)
✔ Browser
✔ Node

? How would you like to define a style for your project? … 
  Use a popular style guide
  Answer questions about your style
▸ Inspect your JavaScript file(s)

? Which file(s), path(s), or glob(s) should be examined? ‣ ./**/*.js

? What format do you want your config file to be in? … 
▸ JavaScript
  YAML
  JSON

In short:

✔ How would you like to use ESLint? · style
✔ What type of modules does your project use? · commonjs
✔ Which framework does your project use? · none
✔ Does your project use TypeScript? · No / Yes
✔ Where does your code run? · browser, node
✔ How would you like to define a style for your project? · auto
✔ Which file(s), path(s), or glob(s) should be examined? · ./**/*.js
✔ What format do you want your config file to be in? · JavaScript

Here is what I ran:

# Note: index.js is empty
touch index.js && npm init -y && npx eslint --init

@mdjermanovic
Copy link
Member

Thanks for the additional info!

Confirmed, I'm working on the fix.

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Feb 2, 2021
@mdjermanovic mdjermanovic added this to Ready to Implement in Triage Feb 2, 2021
@mdjermanovic mdjermanovic moved this from Ready to Implement to Pull Request Opened in Triage Feb 2, 2021
Triage automation moved this from Pull Request Opened to Complete Feb 10, 2021
This was referenced Mar 17, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Aug 10, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.