Fix: --init crash on question to upgrade/downgrade ESLint (fixes #13978) #13995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
fixes #13978
What changes did you make? (Give an overview)
Fixed the
--init
"upgrade/downgrade ESLint" prompt to get the expectedanswers
object.It used to crash because the argument passed into
message()
wasstate
, notanswers
. Thus,localESLintVersion
andrequiredESLintVersionRange
properties were undefined, and thensemver.ltr(undefined, undefined)
throws.Is there anything you'd like reviewers to focus on?
eslint-config-standard
(which requires eslint^7.12.1
, so an upgrade is needed) and it seems to be working fine.message()
apparently getsstate
as the argument (notanswers
). The fix could have been to getanswers
property from the argument. However, I couldn't find this documented, so decided to usethis.state.answers
, like in the rest of the code.