Update: check logical assignment operators in the complexity rule

[mdjermanovic]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What rule do you want to change?

complexity

Does this change cause the rule to produce more or fewer warnings?

more

How will the change be implemented? (New option, new default behavior, etc.)?

new default behavior

Please provide some example code that this change will affect:

/*eslint complexity: ["error", 3]*/

function foo() {
  a &&= bar;
  b ||= bar;
  c ??= bar;
}

What does the rule currently do for this code?

no errors

What will the rule do after it's changed?

report an error that function foo has a complexity of 4.

What changes did you make? (Give an overview)

Changed the complexity rule to increment complexity on each &&=, ||=, or ??=.

Is there anything you'd like reviewers to focus on?

This was originally planned for the next major release, but given the recent semver policy update we can release this change in a minor version.

I marked this as accepted since the rule already reports equivalent and nearly equivalent code:

/*eslint complexity: ["error", 3]*/

// error
function foo() {
  a = a && bar;
  b = b || bar;
  c = c ?? bar;
}

// error
function foo() {
  a && (a = bar);
  b || (b = bar);
  c ?? (c = bar);
}

// error
function foo() {
  if (a) a = bar;  
  if (!b) b = bar;
  if (c == null) c = bar;
}

// currently no error
function foo() {
  a &&= bar;
  b ||= bar;
  c ??= bar;
}

online demo

[yeonjuan]

LGTM! 👍