Extra indenting in a nested ternary with offsetTernaryExpressions: true from Standard JS config

[brodybits]

Tell us about your environment

• ESLint Version: 7.16.0
• Node Version: 14.5.3
• npm Version: 6.14.9

What parser (default, @babel/eslint-parser, @typescript-eslint/parser, etc.) are you using?

default

Please show your full configuration:

Here is the configuration from my work in brodybits/react-native-module-init#85 but with Prettier items removed since they are not needed to reproduce this issue:

Configuration

parserOptions:
  ecmaVersion: 9

extends:
  - standard

plugins:
  - jest

env: { jest/globals: true }

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

Reduced reproduction code that I made in a local mock.test.js file:

const mockCallSnapshot = []

jest.mock('execa', () => (cmd, args, opts) => {
  mockCallSnapshot.push({ execa: [cmd, args, opts] })
  return cmd === 'git'
    ? args[1] === 'user.email'
      ? Promise.resolve({ stdout: 'alice@example.com' })
      : Promise.resolve({ stdout: 'Alice' })
    : Promise.resolve()
})

npx eslint mock.test.js

What did you expect to happen?

no errors

What actually happened? Please include the actual, raw output from ESLint.

/Users/brodybits/dev/react-native-module-init/mock.test.js
  7:1  error  Expected indentation of 8 spaces but found 6  indent
  8:1  error  Expected indentation of 8 spaces but found 6  indent

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

npx eslint --fix mock.test.js updates the code with extra indenting in the nested ternary like this:

const mockCallSnapshot = []

jest.mock('execa', () => (cmd, args, opts) => {
  mockCallSnapshot.push({ execa: [cmd, args, opts] })
  return cmd === 'git'
    ? args[1] === 'user.email'
        ? Promise.resolve({ stdout: 'alice@example.com' })
        : Promise.resolve({ stdout: 'Alice' })
    : Promise.resolve()
})

I was able to reproduce this issue more simply with the following fragment in the test suite:

        {
            code: unIndent`
              condition1
                ? condition2
                  ? Promise.resolve(1)
                  : Promise.resolve(2)
                : Promise.resolve(3)
            `,
            options: [2, { offsetTernaryExpressions: true }]
        },

Are you willing to submit a pull request to fix this bug?

Yes.

I was able to make a one-line fix based on bb6cf50 (PR #12556) by @sheerun:

One-line fix

--- a/lib/rules/indent.js
+++ b/lib/rules/indent.js
@@ -1178,6 +1178,7 @@ module.exports = {
                     offsets.setDesiredOffset(colonToken, firstToken, 1);
 
                     offsets.setDesiredOffset(firstConsequentToken, firstToken,
+                        firstConsequentToken.type === "Punctuator" &&
                         options.offsetTernaryExpressions ? 2 : 1);
 
                     /*

This issue is in follow-up to the offsetTernaryExpressions option contributed in PR #12556 and has led to standard/standard#1624.

/cc @sheerun

[nzakas]

Confirmed.

[brodybits]

Thanks! I will fix the commit message in the next 1-2 days.

On Fri, Jan 29, 2021 at 12:59 PM Nicholas C. Zakas ***@***.***> wrote: Confirmed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13971 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAL42UFWZBWIZ5PS6B7EOWTS4LZOPANCNFSM4VP4JANQ> .

-- Sent from my mobile