Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update JSON Schema links #13936

Merged
merged 1 commit into from Dec 18, 2020
Merged

Docs: update JSON Schema links #13936

merged 1 commit into from Dec 18, 2020

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Updated JSON Schema links in working-with-rules:

  • Two links are just updated to https:// (http://json-schema.org doesn't redirect to https:// so it used to end up with the "Not secure" warning).
  • Understanding JSON Schema is no more maintained in the spacetelescope repo. The redirection still works but may be dropped in the future, so I updated the link to the actual URL.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Dec 17, 2020
@mdjermanovic mdjermanovic merged commit d93c935 into master Dec 18, 2020
@mdjermanovic mdjermanovic deleted the json-schema-links branch December 18, 2020 17:47
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 17, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants