Docs: Remove for deleted npm run profile script #13931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script was deleted in #11854 after it stopped working when we moved from Browserify to webpack. This commit removes the leftover docs and two of the three benchmark files. `large.js` is used by a test case ensuring we can read > 4k data from stdin. If we eventually add in a new profile command, we'll likely want new examples anyway that contain more modern JS rather than just the ES5 examples we had before.
btmills
added
documentation
mdjermanovic
added
accepted
Makes sense to me! And makes sense to remove docs for a script that doesn't exist at the moment, until we add it again. |
mdjermanovic
approved these changes
Dec 18, 2020
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
The
npm run profilescript was deleted in #11854 after it stopped working when we moved from Browserify to webpack. This commit removes the leftover docs and two of the three benchmark files.large.jsis still used by a test case ensuring we can read > 4k data from stdin.Is there anything you'd like reviewers to focus on?
I felt safe deleting the previous benchmark examples because if we eventually add in a new profile command, we'll likely want new examples anyway that contain more modern JS rather than just the ES5 examples we had before.