Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: file-entry-cache@6.0.0 #13877

Merged
merged 1 commit into from Dec 5, 2020
Merged

Upgrade: file-entry-cache@6.0.0 #13877

merged 1 commit into from Dec 5, 2020

Conversation

realityking
Copy link
Contributor

@realityking realityking commented Nov 24, 2020 •
edited

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: upgrading file-entry-cache to version 6. This drops the indirect dependency on write. See jaredwray/flat-cache#49

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Nov 24, 2020
@mdjermanovic mdjermanovic added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion upgrade This change is related to a dependency upgrade and removed triage An ESLint team member will look at this issue soon labels Nov 24, 2020
@mdjermanovic
Copy link
Member

Thanks for the PR!

Is required Node version the only breaking change in file-entry-cache@6.0.0?

@realityking
Copy link
Contributor Author

Yes it is. And it was explicitly aligned to that of eslint.

btmills
btmills approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for going out of your way to align the supported versions!

Marking as "accepted" after mdjermanovic and nzakas mentioned this as good to go in today's release discussion.

@btmills btmills added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Dec 5, 2020
@btmills btmills merged commit 0eb7957 into eslint:master Dec 5, 2020
@realityking realityking deleted the file-entry-cache branch December 5, 2020 10:13
@realityking
Copy link
Contributor Author

The thanks for aligning with eslint version should go to @royriojas who made it happen :)

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 4, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@btmills btmills btmills approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion upgrade This change is related to a dependency upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@realityking @mdjermanovic @btmills