Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: check template literal in no-script-url #13775

Merged
merged 5 commits into from Oct 23, 2020
Merged

Update: check template literal in no-script-url #13775

merged 5 commits into from Oct 23, 2020

Conversation

yeonjuan
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Add template literal checking in no-script-url. :)

Is there anything you'd like reviewers to focus on?

no

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 20, 2020
@yeonjuan yeonjuan added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Oct 20, 2020
@mdjermanovic
Copy link
Member

I support treating this as a bug.

Similar changes in other rules were accepted as semver-minor bug fixes:

@mdjermanovic mdjermanovic added the enhancement This change enhances an existing feature of ESLint label Oct 20, 2020
mdjermanovic
mdjermanovic reviewed Oct 20, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two questions, and I think we should change the commit message (or just PR title if there will be additional commits) to Update: :)

lib/rules/no-script-url.js Show resolved Hide resolved
lib/rules/no-script-url.js Outdated Show resolved Hide resolved
@yeonjuan yeonjuan changed the title Fix: check template literal in no-script-url Update: check template literal in no-script-url Oct 21, 2020
@yeonjuan
Copy link
Member Author

Left two questions, and I think we should change the commit message (or just PR title if there will be additional commits) to Update: :)

@mdjermanovic Sure :) I changed it. Thanks for the review

mdjermanovic
mdjermanovic reviewed Oct 22, 2020
View reviewed changes
lib/rules/no-script-url.js Outdated Show resolved Hide resolved
lib/rules/no-script-url.js Outdated Show resolved Hide resolved
mdjermanovic
mdjermanovic approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

btmills
btmills approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @yeonjuan! And thanks @mdjermanovic for linking precedent for treating this like a bug previously.

@btmills btmills merged commit 5183b14 into master Oct 23, 2020
@btmills btmills deleted the temp-literal-no-script-url branch October 23, 2020 23:32
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Apr 22, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@btmills btmills btmills approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yeonjuan @mdjermanovic @btmills