Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix the format option name in the document #13770

Merged
merged 1 commit into from Oct 20, 2020
Merged

Docs: Fix the format option name in the document #13770

merged 1 commit into from Oct 20, 2020

Conversation

ganta
Copy link
Contributor

@ganta ganta commented Oct 18, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The correct name of the option to specify the output format is --format, but it was described as --formatter, so it has been fixed.

Is there anything you'd like reviewers to focus on?

Nothing. This is a tiny contribution.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 18, 2020
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Oct 18, 2020
@mdjermanovic
Copy link
Member

Good catch, thanks for the PR!

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 👍

@mdjermanovic mdjermanovic merged commit b025795 into eslint:master Oct 20, 2020
@mdjermanovic
Copy link
Member

Thanks for contributing!

@ganta ganta deleted the fix-format-option-name-in-document branch October 20, 2020 13:13
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Apr 19, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants