New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Remove more ESLintRC-related files (refs #13481) #13762
Conversation
Hi @nzakas!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
Hi @nzakas!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
Apologies, I thought this was ready but then the last step seemed to mess everything up. I'll continue working. |
Hi @nzakas!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
Hi @nzakas!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
Hi @nzakas!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
Removed leading and trailing spaces from the title. |
I had to adjust the coverage settings across all four dimensions to get this to pass, but I think it's worth it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I underestimated just how much code extracting eslintrc would remove from core.
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merging this into today's release so you can keep working.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
As part of #13481, I've refactored tests to avoid using the in-memory filesystem helper.
What changes did you make? (Give an overview)
Changed tests for
CLIEngine
,ESLint
, andFileEnumerator
to use an actual filesystem instead of an in-memory one. Also removedCascadingConfigArrayFactory
andConfigArrayFactory
as these are now included from@eslint/eslintrc
.I didn't remove the in-memory filesystem utility because it is still in use by some other tests.
Is there anything you'd like reviewers to focus on?
Did I miss any related functionality?