New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: support async arrow fn in function-paren-newline (fixes #13728) #13729
Conversation
Hi @mdziekon!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdziekon thanks for finding and fixing this bug!
The code and very comprehensive tests look great.
I have just a small request about the commit message. Since this is a bug fix that can produce more warnings, the commit message should start with Update:
instead of Fix:
(this is important for our semver policy).
The message could be something like this:
Update: support async arrow fn in function-paren-newline (fixes #13728)
@mdjermanovic sure thing, I've pushed an amended commit message. |
function-paren-newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM! Thanks
Thanks for contributing! |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Bug fix (fixes #13728)
What changes did you make? (Give an overview)
Added support for the
async
ArrowFunctionExpression infunction-paren-newline
. This fixes the issue where source analysis for this node type wrongly assumes that it does not have an opening parenthesis (because it thinks that in this case, opening paren is always the first token, which since ES2017 is no longer a guarantee).Is there anything you'd like reviewers to focus on?
No