Chore: Move comment to make tests more organized #13707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: Move a comment in the
getter-return
test, so that the orders of tests will make sense.What changes did you make? (Give an overview)
Currently, a part of the
getter-return
tests look like:eslint/tests/lib/rules/getter-return.js
Lines 221 to 226 in 30b76c9
Seeing this, it is quite natural that we think
{allowImplicit: true}
is applied only to line 226. But in fact,{allowImplicit: true}
is also applied to line 221-223 - it's really confusing.So I have moved this comment up, which indicates that this comment is applied to these 4 test cases.
Is there anything you'd like reviewers to focus on?
no