New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: fix examples in object-curly-newline #13605
Docs: fix examples in object-curly-newline #13605
Conversation
a3567ba
to
d9c6315
Compare
Hi @soobing, thanks for the PR! Makes sense to me, marked as accepted. It's usually good to have matching examples in "correct" and "incorrect" sections, though it isn't always possible. Also, it seems we had some wrong examples. |
@mdjermanovic |
Looks great! Can you please fix the linting error: it seems there's a tab at the beginning of line You can check this locally with |
@mdjermanovic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for contributing! |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
The example of correct/incorrect really helpful to user.
So if not match between these two, can give confusion.
When I was reading in
object-curly-newline
docs there was not matching example in case ofconsistent
.Is there anything you'd like reviewers to focus on?
I'm not sure that I correctly added example in correct case. So I ask to review to focus on pair between correct case and incorrect case.