Update: Add disallowTemplateShorthand option in no-implicit-coercion

[remcohaszing]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This adds the templateString option to no-implicit-coercion. This makes the
rule report the following code:

`${foo}`

For backwards compatibility, this was added as a separate option instead of as
default behaviour.

Is there anything you'd like reviewers to focus on?

Closes #12866

[kaicataldo]

Since the linked issue wasn't accepted, we'll need to go through the acceptance process in this PR. I've added my support for the proposal.

[remcohaszing]

This also resolves a race condition in the fixers of prefer-template and no-implicit-coercion.

Input

'' + foo;

Output when autofixed by prefer-template:

`${foo}`;

Output by no-implicit-coercion

String(foo);

This option will still trigger no-implicit-coercion after prefer-template has run its autofixer, meaning there is only one correct way to write this string conversion if both rules are enabled.

[remcohaszing]

I’m not getting a lot of feedback. As far as I can tell this pull request can be merged. Does this require any actions from my side?

[mdjermanovic]

@remcohaszing this enhancement hasn't been accepted yet, per our process it still needs a champion from the team.

[mdjermanovic]

I can champion this.

[mdjermanovic]

@remcohaszing thanks for the quick responses! This looks good, I have only some small suggestions about the documentation.

[mdjermanovic]

LGTM, thanks!

[mdjermanovic]

Thanks for contributing!

[remcohaszing]

Thanks for your code reviews!