New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbolic links are ignored #13551
Symbolic links are ignored #13551
Comments
As a temporary solution, does this work as expected (without the patch you made): eslint --ext ts -c .eslintrc.json src src/shared |
Tried to run eslint v6.8.0 enters target dirs and lints files inside. eslint v7.0.0 doesn't. The latest eslint v7.6.0 also doesn't. @mysticatea I think this was changed in #12700 where some calls of |
This approach works and it's more simple than the current workaround I have. Thanks for the hint @mdjermanovic ! |
Unfortunately, it looks like there wasn't enough interest from the team Thanks for contributing to ESLint and we appreciate your understanding. |
Reopening, as this is most likely a bug. |
Our directory structure has symlinks for all files that aren't checked out in our source control, thus giving us no results now. Is there any workaround for this, short of scanning for the files myself and passing every one in? |
I think we should fix this in ESLint.
A (far from ideal) workaround could be to let the shell do that, by using globs that will be expanded to individual file paths instead of passed to ESLint, if that's possible. |
@mdjermanovic Delay is not a problem, I'm glad the issue is accepted :) I'm still willing to submit a PR to fix this bug, I'll try to open one as soon as possible. I'm also going to keep in mind that this problem is related to #13615. |
@vjekoart @mdjermanovic do you have any updates on this one? |
I'm also interested if there are any plans to fix this |
This will be fixed by #14126 |
What parser (default, Babel-ESLint, etc.) are you using?
@typescript-eslint/parser
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.
// Not relevant, since files are analysed correctly, but not all files are checked.
# This command is executed from `package.json`, i.e. this code is under the `scripts.lint` property. eslint --ext ts -c .eslintrc.json src
What did you expect to happen?
I'm working on a project which has the following structure of
src
directory:I've some errors in TS files inside
src/shared/
directory. I expected errors and warnings from ESLint when running a lint action.What actually happened? Please include the actual, raw output from ESLint.
All files, except those in
src/shared/
directory have been checked for errors.After some research, I've identified method
_iterateFilesRecursive
as problematic inlib/cli-engine/file-enumerator.js
file.Inside that function all entries inside a specific directory are checked if they are a file or a folder. But if entry is a symbolic link, it's completely ignored.
Currently, I've made a workaround to patch aforementioned file with modified version of
_iterateFilesRecursive
method. Of course, that solution is not good since I'm locked to a specific version of ESLint package.Modified version of `_iterateFilesRecursive`
Are you willing to submit a pull request to fix this bug?
Yes.
The text was updated successfully, but these errors were encountered: