Update: object-property-newline end location (refs #12334)

[anikethsaha]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

removed the .start of the reporting location to include both start and end as well.

Is there anything you'd like reviewers to focus on?

Currently, the location of the key is being reported (both in master and in this PR)
Will it make sense to report the leading whitespace?

like this

by replacing the loc

loc: {
   start: comma.loc.end,
  end: firstTokenOfCurrentProperty.loc.start
}

Change of heart!

[kaicataldo]

I think reporting the whitespace as suggested above makes more sense, personally!

[anikethsaha]

Cool, I will change that 👍

[nzakas]

The change itself looks fine. Can you please add a test?

[anikethsaha]

cool

[nzakas]

LGTM. Thanks!

[btmills]

LGTM, and thanks for knocking another one of these rules out, @anikethsaha!

I noticed that just one of the tests hadn't yet had endLine/endColumn added, so I pushed a quick commit to add those to save you time.

While the suggestion to report the whitespace before the key rather than the key itself would be neat, it could drastically complicate the implementation due to potential placement of the comma, so I think warning on the key as we've been doing (now with an end location) is perfectly adequate.

[anikethsaha]

I noticed that just one of the tests hadn't yet had endLine/endColumn added, so I pushed a quick commit to add those to save you time.

Thanks a lot 💯