Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fixed broken hash link for working-with-rules.md #13386

Merged
merged 1 commit into from Jun 4, 2020
Merged

Docs: fixed broken hash link for working-with-rules.md #13386

merged 1 commit into from Jun 4, 2020

Conversation

ota-meshi
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fixed broken hash link.

Is there anything you'd like reviewers to focus on?

No.

@jsf-clabot
Copy link

jsf-clabot commented Jun 3, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jun 3, 2020
yeonjuan
yeonjuan approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@yeonjuan yeonjuan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :) mistakes

yeonjuan
yeonjuan suggested changes Jun 3, 2020
View reviewed changes
Copy link
Member

@yeonjuan yeonjuan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! can you change the commit message and sign our Contributor License Agreement?

@yeonjuan yeonjuan added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Jun 3, 2020
@ota-meshi ota-meshi changed the title Update working-with-rules.md Docs: fixed broken hash link for working-with-rules.md Jun 3, 2020
@ota-meshi
Copy link
Member Author

Thank you for letting me know. I changed the title and signed.

@ota-meshi ota-meshi requested a review from yeonjuan June 3, 2020 13:35
@ota-meshi
Copy link
Member Author

Oops. I didn't notice I had to fix it from the commit message.
I also fixed the commit message.

yeonjuan
yeonjuan approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ota-meshi
Thanks for the changing:) LGTM!

@kaicataldo kaicataldo merged commit 21b1583 into eslint:master Jun 4, 2020
@kaicataldo
Copy link
Member

Thanks for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 2, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@yeonjuan yeonjuan yeonjuan approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ota-meshi @jsf-clabot @kaicataldo @yeonjuan